Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct filename is displayed in Start/Stop messages #69

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Commits on May 18, 2024

  1. Ensure that 'start logging' displays correct filename

    Previously the filename was calculated twice: first when opening the
    file, and then when displaying the message.  There is a small chance
    that the time would change between those two events, causing the
    displayed filename to be incorrect.  This change calculates the name
    once and then uses that name in both places.
    Phil Hindman committed May 18, 2024
    Configuration menu
    Copy the full SHA
    c2854b2 View commit details
    Browse the repository at this point in the history
  2. Add get_logging_variable helper function

    Phil Hindman committed May 18, 2024
    Configuration menu
    Copy the full SHA
    6455c71 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Simplify get/set logging variable

    Use a pane option variable, and remove unnecessary script variables.
    Phil Hindman committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    d99a25a View commit details
    Browse the repository at this point in the history
  2. Set/unset logging variable

    Set it in start_pipe_pane, unset it in stop_pipe_pane, and determine
    whether logging is on by whether it is set or unset.
    Phil Hindman committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    88bd8e1 View commit details
    Browse the repository at this point in the history
  3. Store logging filename in @logging-variable

    Since the string stored in @logging-variable can be arbitrary, let's
    store the filename there, so that we can display the correct name when
    we stop logging.
    Phil Hindman committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    5fad487 View commit details
    Browse the repository at this point in the history
  4. Rename functions/variables to reflect current usage

    The name of the file that the current pane is logging to is stored in
    the variable, so name it (and the helper functions) accordingly.
    Phil Hindman committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    5f03ad0 View commit details
    Browse the repository at this point in the history