Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: update grpc to 1.56.0 #621

Merged
merged 7 commits into from
Jul 19, 2023
Merged

*: update grpc to 1.56.0 #621

merged 7 commits into from
Jul 19, 2023

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Jul 9, 2023

No description provided.

@BusyJay
grpcio-sys: update to 1.56.0
3fda7b8 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
update deps
617b4cc 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
fix missing lib
38bf183 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
update grpc to 1.65.0
f7bbbd2 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay BusyJay requested review from overvenus and tabokie July 9, 2023 08:29
@BusyJay
fix clippy
4c8f5e2 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay BusyJay mentioned this pull request Jul 13, 2023
Closed
overvenus
overvenus approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@BusyJay
fix windows failure
fc209d1 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
fix publish failure
339c325 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Connor1996
Connor1996 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Connor1996 Connor1996 merged commit 455bc4b into tikv:master Jul 19, 2023
9 checks passed
@BusyJay
Copy link
Member Author

BusyJay commented Jul 19, 2023

I was thinking also update to 1.56.2 before merge 😆

@BusyJay BusyJay deleted the update-grpc-to-1.56.0 branch July 19, 2023 02:12
@BusyJay BusyJay mentioned this pull request Jul 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

@tabokie tabokie tabokie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BusyJay @overvenus @Connor1996 @tabokie