Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark adds four new data types: STRING BLOB TIMESTAMP DATE #434
Benchmark adds four new data types: STRING BLOB TIMESTAMP DATE #434
Changes from 3 commits
c21ab90
425375f
215841f
641a848
d867487
f539321
ad84d8d
4995f3d
73fe797
1802e26
c96a642
2d99c4b
a8c96d0
e9d9906
f0ba833
320a84e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can keep consistent with default value in config here. 1:1:1:1:1:1:0:0:0:0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
对时序数据为非 iotdb 的场景,目前仍不支持 STRING BLOB TIMESTAMP DATE,因此在 precheck 中添加对类别数的特判。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
magic number 6,在Config类定义一个OLD_xxxxx
magic String “IoTDB”,从一些类型枚举类里找找?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typeNumber 已经改成 TYPENUMBER,能够在配置文件中修改。但修改时要保证其与 INSERT_DATATYPE_PROPORTION 的比例数相同。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
挪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok 放到了ConfigDescribetor.checkConfig()中,每种benchmark 模式都会进行此项配置检查。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里不要改成snapshot版本
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里因为新数据类型是 1.3.3 版本才有的,为了本地方便可以先搞成快照版本,这样本地 mvn install 就能直接用了。
反正这个 PR 暂不合并,我们大家都 review 完打个包给测试组就行。
等后面开源版 1.3.3 发出来了,我们就替换成 1.3.3,然后合并这个 PR