[Refactor] Extract common logic from IoTDBSession and IoTDBClusterSession #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OneSizeFitsQuorum
approved these changes
Jun 5, 2023
SpriCoder
requested changes
Jun 5, 2023
Comment on lines
39
to
73
| private final SessionPool sessionPool; | ||
| public BenchmarkSessionPool(SessionPool sessionPool) { | ||
| this.sessionPool = sessionPool; | ||
| } | ||
| @Override | ||
| public void open() { | ||
|
|
||
| } | ||
| @Override | ||
| public void open(boolean enableRPCCompression) { | ||
|
|
||
| } |
There was a problem hiding this comment.
Maybe we need to init SessionPool in BenchmarkSessionPool instead of passing sessionpool into BenchmarkSessionPool
liyuheng55555
force-pushed
the
mergeSessionAndClusterSession
branch
2 times, most recently
from
bb992e1
to
277abd8
Compare
liyuheng55555
force-pushed
the
mergeSessionAndClusterSession
branch
from
277abd8
to
db21c40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.