Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Consume a task as an operation. #915

Merged
merged 1 commit into from
Oct 25, 2024
Merged

🐛 Consume a task as an operation. #915

merged 1 commit into from
Oct 25, 2024

Commits on Oct 25, 2024

  1. 🐛 Consume a task as an operation.

    Tasks are supposed to be both operations _and_ promises. However, I
    had forgotten to make the task consumaeble as an operation, and only a
    promise. However, because we were monkey-patching `Promise.prototype`,
    it was actually hiding the gap because everywher we needed to consume
    a task as an operation, it just used the promise as operation route.
    
    I added back the operation functionality, but at the same time, I
    actually removed the monkey-patch of `Promise.prototype` for our test
    suite so that we are forced to follow the operation pathway
    explicitly. That way, we won't risk regressing back to non-functioning
    operation tasks. It does make the tests a little more verbose, but the
    added safety is worth it.
    cowboyd committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    512fcd1 View commit details
    Browse the repository at this point in the history