Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36230 - Puppet removal parameter to installer is no longer used #702

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Mar 27, 2023

No description provided.

@ehelms
Copy link
Member Author

ehelms commented Mar 27, 2023

I've a proposed a test to ensure this over in bats: theforeman/forklift#1664

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something which should take the version into account? If this is cherry picked to an older release then it'll break things. If not, I think the min version should be raised to 3.6.

@ehelms
Copy link
Member Author

ehelms commented Mar 27, 2023

Is this something which should take the version into account? If this is cherry picked to an older release then it'll break things. If not, I think the min version should be raised to 3.6.

I would assume if you cherry pick this back to an older release you are doing so with the intent to provide this functionality to that older release.

But since those checks exist, I can update them. They are a hold over from the previous release model foreman_maintain was used in with Satellite.

@ekohl ekohl changed the title Puppet removal parameter to installer is no longer used Fixes #36230 - Puppet removal parameter to installer is no longer used Mar 28, 2023
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ekohl ekohl merged commit 4c35d1c into theforeman:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants