Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login vulnerabilities #94

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Fix login vulnerabilities #94

merged 3 commits into from
Jul 12, 2024

Conversation

tnylea
Copy link
Contributor

@tnylea tnylea commented Jul 11, 2024

Re-creating this PR #91 to a branch that is on the main repo in order to get the tests to run and pass successfully.

Will wait til tests run/pass and then get this merged in.

@tnylea tnylea mentioned this pull request Jul 11, 2024
@tnylea
Copy link
Contributor Author

tnylea commented Jul 11, 2024

Really appreciate it @Lakshan-Madushanka, getting this one merged in as well 👍

@Lakshan-Madushanka
Copy link
Contributor

Saw these vulnerabilities while coding for another issue.

I tested this before pushing and it all passed but it was quite tricky. I had to install all the testing-related dependencies in a Laravel project, then copy and paste all the package's tests into the Laravel project's test directory. Afterward, I realized why the test namespace is in Tests. This must be the reason you need to create separate branches and follow the above process.

This might be due to the difficulty of setting up the test environment within the package itself, especially for Dusk tests. I suggest including guidance on this testing procedure in the documentation, as it could be subtle for some contributors.

Thanks for this great package.

@tnylea
Copy link
Contributor Author

tnylea commented Jul 12, 2024

💯 @Lakshan-Madushanka thanks for the feedback 😉

@tnylea tnylea merged commit 7c3c85f into main Jul 12, 2024
2 checks passed
@tnylea tnylea deleted the Fix-login-vulnerabilities branch July 12, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants