Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 'static' instead of 'self' in static returning methods #284

Open
wants to merge 1 commit into
base: 5.3
Choose a base branch
from

Conversation

donjajo
Copy link

@donjajo donjajo commented Mar 19, 2024

Extending classes need to return itself

Extending classes need to return itself
@homersimpsons
Copy link
Collaborator

LGTM, thank you!

@homersimpsons
Copy link
Collaborator

Actually it looks like this is not available for php 7.4. It is available since PHP8.0.

@moufmouf are you okay to upgrade the minimum php version to PHP8.0?

@moufmouf
Copy link
Member

@homersimpsons Definitely ok if you tag a new minor (or major) release (don't do this in a patch release)

@homersimpsons
Copy link
Collaborator

@donjajo Can you upgrade the php requirement in composer.json?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants