retry for other region #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnsetting2023
force-pushed
the
redirect_for_other_endpoint
branch
2 times, most recently
from
62f4395
to
ba1f786
Compare
aaronpkahn
reviewed
Sep 27, 2024
aaronpkahn
reviewed
Sep 27, 2024
tnsetting2023
force-pushed
the
redirect_for_other_endpoint
branch
from
ba1f786
to
0a515b7
Compare
elffjs
reviewed
Sep 30, 2024
tnsetting2023
force-pushed
the
redirect_for_other_endpoint
branch
2 times, most recently
from
1d04436
to
a514512
Compare
tnsetting2023
force-pushed
the
redirect_for_other_endpoint
branch
2 times, most recently
from
00bec7c
to
a81d234
Compare
sethterashima
approved these changes
Oct 16, 2024
agbpatro
reviewed
Oct 17, 2024
agbpatro
reviewed
Oct 17, 2024
tnsetting2023
force-pushed
the
redirect_for_other_endpoint
branch
from
a81d234
to
babf86c
Compare
agbpatro
approved these changes
Oct 17, 2024
elffjs
reviewed
Oct 18, 2024
| proxyReq.URL.Host = acct.Host | ||
| log.Debug("Forwarding request to %s", proxyReq.URL.String()) | ||
| client := http.Client{} | ||
| result, err := client.Do(proxyReq) |
There was a problem hiding this comment.
Sorry to resurrect this but I worry this isn't going to work. This proxyReq is assigned a request body of req.Body at the start of the function on line 182, but on line 213 we drain req.Body completely, so I think we're never going to send a body here.
In testing, stuff like fleet_status is failing every time when Tesla validates the request body. Just GET-ing data is working, however.
Sorry, I should have noticed this earlier.
There was a problem hiding this comment.
Maybe on line 218 we should write
proxyReq.Body = io.NopCloser(bytes.NewBuffer(requestBody))?
There was a problem hiding this comment.
Thanks for testing this out. Indeed. the proxyReq is the real request being sent out. Will fxi it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
currently vehicle command will retry commands if tesla host return 421. We want to share the same behavior for other proxied request as well.
Fixes # (issue)
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: