Add support for explicitly Finite non-implications #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in [1], I add support to the @[equational_result] attribute to parse non-implication theorems with Finite typeclasses. I then add support to `extract_implications` to specify `--finite-only` to limit results to finite non-implications. In addition, I also add some additional checking to @[equational_result] as previously it would silently mis-parse theorems with the Finite typeclass. This was tested by generating `extract_implications` closure/unknowns results before and after this change. When I included finite non-implications (not in this change), the results correctly showed them with `--finite-only`, while the results without `--finite-only` did not change and match the results prior to this change. [1] https://leanprover.zulipchat.com/#narrow/channel/458659-Equational/topic/Proposal.3A.20Add.20Finite.20typeclasses.20to.20non-implications/near/477933508
|
Am merging this for now but one should do some further checks once more implications are converted to |
codyroux
pushed a commit
to codyroux/equational_theories
that referenced
this pull request
Oct 21, 2024
As discussed in [1], I add support to the @[equational_result] attribute to parse non-implication theorems with Finite typeclasses. I then add support to `extract_implications` to specify `--finite-only` to limit results to finite non-implications. In addition, I also add some additional checking to @[equational_result] as previously it would silently mis-parse theorems with the Finite typeclass. This was tested by generating `extract_implications` closure/unknowns results before and after this change. When I included finite non-implications (not in this change), the results correctly showed them with `--finite-only`, while the results without `--finite-only` did not change and match the results prior to this change. [1] https://leanprover.zulipchat.com/#narrow/channel/458659-Equational/topic/Proposal.3A.20Add.20Finite.20typeclasses.20to.20non-implications/near/477933508
teorth
pushed a commit
that referenced
this pull request
Oct 25, 2024
#702 added support for Finite non-implications, this add support for Finite implications as well. I update the extract_implications script to always default to 'non-finite' results, and I've verified that the outputs of `lake exe extract_implications` outputs for every subcommand match what they were prior to this change, despite marking a number of Finite results with `@[equational_result]` in this change [modulo the two non-finite theorems I added the attribute to as well.] Note that reviewing by commit might be slightly easier, as the first and last commits are a trivial update and a simple refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in [1], I add support to the @[equational_result] attribute to parse non-implication theorems with Finite typeclasses. I then add support to
extract_implicationsto specify--finite-onlyto limit results to finite non-implications.In addition, I also add some additional checking to @[equational_result] as previously it would silently mis-parse theorems with the Finite typeclass.
This was tested by generating
extract_implicationsclosure/unknowns results before and after this change. When I included finite non-implications (not in this change), the results correctly showed them with--finite-only, while the results without--finite-onlydid not change and match the results prior to this change.[1] https://leanprover.zulipchat.com/#narrow/channel/458659-Equational/topic/Proposal.3A.20Add.20Finite.20typeclasses.20to.20non-implications/near/477933508