Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean-up: Eliminate try {}s #638

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

clean-up: Eliminate try {}s #638

wants to merge 3 commits into from

Conversation

vlad902
Copy link
Contributor

@vlad902 vlad902 commented Oct 18, 2024

Marginally improves build times but more importantly makes the theorems far easier to understand.

vlad902 and others added 2 commits October 18, 2024 22:43
Marginally improves build times but more importantly makes the theorems
far easier to understand.
@pitmonticone
Copy link
Collaborator

Thanks @vlad902! Do we want to "touch" ATP generated proofs, @teorth?

If so I can focus on golfing those in the next few days.

@pitmonticone pitmonticone marked this pull request as draft October 18, 2024 23:46
@teorth
Copy link
Owner

teorth commented Oct 19, 2024

We can, but then we may also want to update the code that generates those proofs as well, otherwise any edits will simply get wiped out if the code is run again.

@pitmonticone
Copy link
Collaborator

Yes, exactly.

@vlad902, can we guarantee that?

@vlad902
Copy link
Contributor Author

vlad902 commented Oct 21, 2024

This is doable, I have a script that already reduces the number of try {}s in the workflow in the README. I will keep this in draft for now and get back to it in a few days.

@pitmonticone
Copy link
Collaborator

Thank you very much @vlad902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants