checksum acceptance criteria for filtering address removed #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for teloscan-stage ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-mainnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pmjanus
approved these changes
Aug 26, 2024
pmjanus
deleted the
837-search-bar-is-showing-no-results-for-a-real-address-search
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #837
Description
At the beginning, the Indexer API was returning each address twice (one in lowercase and the other one in checksum format). That is why we were filtering only the checksum formatted addresses. But now it only returns the lowercase format, so no address results are shown because all of them were filtered out. Now that is fixed, and no filtering is performed at all.
Test scenarios
1 - go to this deployment link
2 - enter: 0x31644692d2c2b7228f9763416e7612451F69009e or any other valid address
3 - see one result