Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

languages txt are sync, some more txt added, tooltips offset added #818

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Aug 6, 2024

Fixes #815

Description

This PR fixes all outdated localization strings for all languages (English, Spanish, French, Portuguese, and German). It also adds some texts that were hard-coded in English. Finally, all tooltips were fixed with an extra offset that makes them appear under the hovering object rather than on top of it.

Test scenarios

  • go to this link
  • set the language to any non-English language
  • explore the site looking for a hard-coded English text
  • play with tooltips looking for a tooling covering the word you cursor is pointing to.

image

@Viterbo Viterbo self-assigned this Aug 6, 2024
Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit c8fa9b0
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/66b215fe9430490007313584
😎 Deploy Preview https://deploy-preview-818--teloscan-stage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for testnet-teloscan ready!

Name Link
🔨 Latest commit c8fa9b0
🔍 Latest deploy log https://app.netlify.com/sites/testnet-teloscan/deploys/66b215fe3d4a360008f9751e
😎 Deploy Preview https://deploy-preview-818--testnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit c8fa9b0
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/66b215fe34ebbf0008806a90
😎 Deploy Preview https://deploy-preview-818--dev-mainnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pmjanus pmjanus merged commit bfc1f9c into dev Aug 13, 2024
13 checks passed
@pmjanus pmjanus deleted the 815-repare-localization-strings branch August 13, 2024 16:14
@Viterbo Viterbo linked an issue Aug 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repare localization strings
2 participants