Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#529 | Redesign - Base styling #538

Merged
merged 6 commits into from
Feb 21, 2024
Merged

#529 | Redesign - Base styling #538

merged 6 commits into from
Feb 21, 2024

Conversation

ezra-sg
Copy link
Contributor

@ezra-sg ezra-sg commented Feb 21, 2024

Fixes #529

Description

This PR cleans out some old styles and introduces some new ones in preparation for the redesign.

Note: the styling on basically every page is now wonky / incorrect. that is because styles that we will not be using in the future were removed, but the new styling has not been implemented. it is out of the scope of this issue to redo every page (of course). so for now, unless anyone objects, I think we should move forward with the site looking busted temporarily, and we will clean up each page as we get to it.

Test scenarios

  • the gradient backgrounds on the home page should look like the new teloscan design - and look good at all breakpoints

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@ezra-sg ezra-sg self-assigned this Feb 21, 2024
Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for teloscan-redesign ready!

Name Link
🔨 Latest commit 34a2303
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-redesign/deploys/65d5419078cac00008aba580
😎 Deploy Preview https://deploy-preview-538--teloscan-redesign.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ezra-sg ezra-sg marked this pull request as ready for review February 21, 2024 00:20
@Viterbo Viterbo mentioned this pull request Feb 21, 2024
10 tasks
@ezra-sg ezra-sg merged commit 3722793 into epic-redesign Feb 21, 2024
5 checks passed
@ezra-sg ezra-sg deleted the 529-new-base-styles branch February 21, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants