Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing unstaking bug #495

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Nov 28, 2023

Fixes #462

Description

Brave Was already incorporated but not tested. With this little fix we have Brave support for the current state of Teloscan

This issue is related to this PR which was canceled

Test scenarios

  • Use brave browser
  • go to this link
  • connect using Brave wallet
  • go to unstake form and unstake any amount
    • it should work normally

@Viterbo Viterbo self-assigned this Nov 28, 2023
Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit ca02f7b
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/656604903f2a6c00083e63bc
😎 Deploy Preview https://deploy-preview-495--teloscan-stage.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit ca02f7b
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/65660490d2b5f40008bf7594
😎 Deploy Preview https://deploy-preview-495--dev-mainnet-teloscan.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo marked this pull request as ready for review November 28, 2023 15:24
@donnyquixotic donnyquixotic merged commit 5de9c96 into dev Nov 28, 2023
9 checks passed
@donnyquixotic donnyquixotic deleted the 462-incorporate-the-new-brave-evmauthenticator branch November 28, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorporate the new Brave EVMAuthenticator to Teloscan and remove legacy code
2 participants