Only check network before transactions

[Viterbo]

Fixes #760

Description

This PR includes a new function assertNetworkConnection for the account store that will prompt the user to change the network and block the code until the user either refuses or accepts and effectively changes the network. That allowed us to reduce a lot of redundant code repeated in several places.

It also removes the code responsible for warning the user that a network switch has been detected because we don't need it if we are only displaying data. However, when the user tries to sign a transaction we need to explicitly check the network and prompt the user to change it.

Test scenarios

• Login using Metamask
• Once logged, open Metamask, change the network, and come back to the web app
  • you should not get any notification
  • you should be able to explore all sections and your data should be correct
• got to any transaction page and try to perform one: send, wrap, unwrap, etc
  • you should be prompted to change the network
  • if you refuse to switch the network, the transaction cancels quietly
  • if you cancel the switch you get a neutral notification
  • if you accept and continue until effectively change the network, the transaction should go on without the need for you to hit the action button again (see the video).

Screen captures

telos-wallet--switch-network-before-trx.webm

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have cleaned up the code in the areas my change touches
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings
• I have removed any unnecessary console messages
• I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
• I have tested for mobile functionality and responsiveness
• I have added appropriate test coverage

[netlify]

✅ Deploy Preview for wallet-develop-mainnet ready!

Name	Link
🔨 Latest commit	e2cf099
🔍 Latest deploy log	https://app.netlify.com/sites/wallet-develop-mainnet/deploys/65d3eed08e6b210009cc8ef1
😎 Deploy Preview	https://deploy-preview-763--wallet-develop-mainnet.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for wallet-staging ready!

Name	Link
🔨 Latest commit	e2cf099
🔍 Latest deploy log	https://app.netlify.com/sites/wallet-staging/deploys/65d3eed0f7dda20008cf0f8e
😎 Deploy Preview	https://deploy-preview-763--wallet-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[donnyquixotic]

@Viterbo

• Remove the switch notification altogether, add a network check and switch prompt to any signed transaction

• remove network switch prompt on autologin

[Viterbo]

@Viterbo

• Remove the switch notification altogether, add a network check and switch prompt to any signed transaction
• remove network switch prompt on autologin

DONE!

[donnyquixotic]

@Viterbo Cannot transfer NFTs if on a different network (no switch prompt). Attempts to send on incorrect network fail to estimate gas or execute as an empty transaction (no transfer).

[Viterbo]

@Viterbo Cannot transfer NFTs if on a different network (no switch prompt). Attempts to send on incorrect network fail to estimate gas or execute as an empty transaction (no transfer).

DONE!

[ezra-sg]

I noticed a problem which is totally not your fault, as it is present in prod, but i think it might fall under the purview of this issue. maybe you can fix it for this PR, what do you think? if not we can make a separate issue to fix it.

On the approvals page, if you attempt to modify an approval while on the wrong network, the transaction will be on the wrong network (note how it says ethereum mainnet):