-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only check network before transactions #763
Conversation
✅ Deploy Preview for wallet-develop-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wallet-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Remove the switch notification altogether, add a network check and switch prompt to any signed transaction
-
remove network switch prompt on autologin
DONE! |
@Viterbo Cannot transfer NFTs if on a different network (no switch prompt). Attempts to send on incorrect network fail to estimate gas or execute as an empty transaction (no transfer). |
DONE! |
Fixes #760
Description
This PR includes a new function
assertNetworkConnection
for the account store that will prompt the user to change the network and block the code until the user either refuses or accepts and effectively changes the network. That allowed us to reduce a lot of redundant code repeated in several places.It also removes the code responsible for warning the user that a network switch has been detected because we don't need it if we are only displaying data. However, when the user tries to sign a transaction we need to explicitly check the network and prompt the user to change it.
Test scenarios
Screen captures
telos-wallet--switch-network-before-trx.webm
Checklist: