Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error if name to address retry ends. #78

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Return error if name to address retry ends. #78

merged 5 commits into from
Oct 14, 2024

Conversation

lesa-telos
Copy link
Contributor

@lesa-telos lesa-telos commented Oct 11, 2024 •
edited
Loading

Fixes ##77

Return an error if name to address retry ends so that consensus client will restart.

Description

Test scenarios

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage
  • I have updated relevant documentation and/or opened a separate issue to cover the updates (Issue URL: )

Base automatically changed from fc-update to master October 13, 2024 17:17
poplexity
poplexity approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@poplexity poplexity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poplexity poplexity merged commit 0627059 into master Oct 14, 2024
4 checks passed
@poplexity poplexity deleted the name-to-address-error branch October 14, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poplexity poplexity poplexity approved these changes

@coa-telos coa-telos coa-telos approved these changes

@aamirpashaa aamirpashaa Awaiting requested review from aamirpashaa

@guilledk guilledk Awaiting requested review from guilledk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lesa-telos @poplexity @coa-telos