Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fc update #73

Merged
merged 26 commits into from
Oct 13, 2024
Merged

Fc update #73

merged 26 commits into from
Oct 13, 2024

Conversation

lesa-telos
Copy link
Contributor

@lesa-telos lesa-telos commented Sep 26, 2024 •
edited
Loading

Fixes 49 #33

Description

  • Call fork choice update only when lib changes.
  • Reduce the batch size to 1 when head is caught.

Test scenarios

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage
  • I have updated relevant documentation and/or opened a separate issue to cover the updates (Issue URL: )

@coa-telos coa-telos force-pushed the fc-update branch 2 times, most recently from 5adec12 to 828163e Compare September 30, 2024 14:41
@lesa-telos lesa-telos marked this pull request as ready for review September 30, 2024 15:11
@coa-telos coa-telos force-pushed the fc-update branch 3 times, most recently from 0861720 to 3b91276 Compare October 2, 2024 18:04
@poplexity poplexity merged commit 1fa753d into master Oct 13, 2024
4 checks passed
@poplexity poplexity deleted the fc-update branch October 13, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poplexity poplexity Awaiting requested review from poplexity

@coa-telos coa-telos Awaiting requested review from coa-telos

@guilledk guilledk Awaiting requested review from guilledk

@aamirpashaa aamirpashaa Awaiting requested review from aamirpashaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fork handling
3 participants
@lesa-telos @poplexity @coa-telos