Mark AVC check as expected when running AVC check test on localhost #3328
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
force-pushed
the
avc-check-now-fails-in-tf
branch
from
15f09e6
to
7e66813
Compare
This is an unexpected consequence of checks being interpreted in 1.38: tmt in TF runs a test, test runs another tmt which triggers an AVC denial, on purpose, but thanks to all this happening on localhost, TF tmt can notice the AVC denial, and report it as a failed check. Adding `xfail` to prevent this.
happz
force-pushed
the
avc-check-now-fails-in-tf
branch
from
7e66813
to
a7d64af
Compare
happz
changed the title
happz
added
code | no functional change
happz
requested review from
psss,
lukaszachy,
thrix and
janhavlin
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an unexpected consequence of checks being interpreted in 1.38:
tmt in TF runs a test, test runs another tmt which triggers an AVC
denial, on purpose, but thanks to all this happening on localhost, TF
tmt can notice the AVC denial, and report it as a failed check. Adding
xfailto prevent this.Pull Request Checklist