Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple links in the tmt link command #3309

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Support multiple links in the tmt link command #3309

merged 2 commits into from
Oct 23, 2024

Conversation

psss
Copy link
Collaborator

@psss psss commented Oct 22, 2024

In order to make the syntax consistent with the tmt test create command and to allow providing multiple links in a single command let's use a --link option instead of the first argument for provide the relation:target pairs.

Pull Request Checklist

  • implement the feature
  • write the documentation
  • include a release note

@psss psss added this to the 1.38 milestone Oct 22, 2024
@psss psss added the command | link tmt link command label Oct 22, 2024
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@seberm seberm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe try to add some basic tests? E.g at least check the error is raised when no link is provided?

In order to make the syntax consistent with the `tmt test create`
command and to allow providing multiple links in a single command
let's use a ``--link`` option instead of the first argument for
provide the `relation:target` pairs.
@psss psss added the ci | full test Pull request is ready for the full test execution label Oct 22, 2024
@psss
Copy link
Collaborator Author

psss commented Oct 22, 2024

Maybe try to add some basic tests? E.g at least check the error is raised when no link is provided?

Makes sense, added in 499d163. Does it look ok, @seberm?

@psss psss merged commit e485608 into main Oct 23, 2024
22 checks passed
@psss psss deleted the tmt-link branch October 23, 2024 07:31
@psss psss self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution command | link tmt link command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants