Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Debian 12.7 among container test images #3306

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Add Debian 12.7 among container test images #3306

merged 2 commits into from
Oct 23, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Oct 21, 2024

Pull Request Checklist

  • implement the feature

@happz happz added code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. test coverage Improvements or additions to test coverage of tmt itself labels Oct 21, 2024
@happz happz added this to the 1.38 milestone Oct 21, 2024
thrix
thrix reviewed Oct 21, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
thrix
thrix approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just silly identation asks

@happz happz added the ci | full test Pull request is ready for the full test execution label Oct 22, 2024
psss
psss approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@psss psss added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Oct 23, 2024
@psss
Copy link
Collaborator

psss commented Oct 23, 2024

The failing test was a network glitch.

@psss psss merged commit b9cf8fa into main Oct 23, 2024
21 of 22 checks passed
@psss psss deleted the test-container-on-debian branch October 23, 2024 12:37
@psss psss self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

@thrix thrix thrix approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. test coverage Improvements or additions to test coverage of tmt itself
Projects
None yet
Milestone
1.38
Development

Successfully merging this pull request may close these issues.
3 participants
@happz @psss @thrix