Wait for guest connection before test restart #3291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
requested review from
psss,
lukaszachy,
thrix and
janhavlin
as code owners
happz
force-pushed
the
test-restart-without-reboot-must-still-wait-for-reconnect
branch
from
96b27f9
to
8036ca5
Compare
happz
force-pushed
the
test-restart-without-reboot-must-still-wait-for-reconnect
branch
2 times, most recently
from
7ba95f2
to
7cd12f2
Compare
therazix
approved these changes
Oct 22, 2024
psss
approved these changes
Oct 22, 2024
Even without a reboot, tmt still needs to verify the guest is up and running. The reboot might be triggered beyond the control of tmt, and that is fine, we just need to be sure we restart the test on guest that's alive. Related to #3284
psss
force-pushed
the
test-restart-without-reboot-must-still-wait-for-reconnect
branch
from
7cd12f2
to
80a0ae1
Compare
psss
added
the
status | ready for merge
psss
deleted the
test-restart-without-reboot-must-still-wait-for-reconnect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even without a reboot, tmt still needs to verify the guest is up and running. The reboot might be triggered beyond the control of tmt, and that is fine, we just need to be sure we restart the test on guest that's alive.
Related to #3284
Pull Request Checklist