Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve quality of generated seed, avoid potential security pitfall #747

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve quality of generated seed, avoid potential security pitfall #747

wants to merge 1 commit into from

Commits on Sep 17, 2024

  1. Improve quality of generated seed, avoid potential security pitfall 

    * Try to use random_bytes() first if it's available
* Do not include the server parameters in the generated seed, as
they might contain sensitive data

As all current usages of getRandomSeed() directly hash the seed,
there should be no BC breaking changes.

The main source of entropy is more than enough on its own if
random_bytes() or openssl_random_pseudo_bytes() are available.
    @xelan
    xelan committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    022689a View commit details
    Browse the repository at this point in the history