Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageSVG() does not calculate the correct w/h values anymore - fix it #661

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

d-javu
Copy link

@d-javu d-javu commented Nov 3, 2023

Fix for issue #660 Automatic calculation of w/h fails for ImageSVG()
The bug appeared in 6.0.031 and was caused by the
'avoid "division by zero"' part of commit: 0c26f23 The fix, for me, is to remove the div_by_zero mitigation.

@CLAassistant
Copy link

CLAassistant commented Nov 3, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, let's see what the author thinks about it

@nicolaasuni
Copy link
Member

Please try to resolve the conflicts.

The bug appeared in 6.0.031 and was caused by the
'avoid "division by zero"' part of commit: 0c26f23
The fix, for me, is to remove the div_by_zero mitigation.
@d-javu
Copy link
Author

d-javu commented Apr 23, 2024

Rebased onto your recently force-pushed main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants