Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove examples from packaging #605

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shyim
Copy link

@shyim shyim commented Apr 5, 2023

image
saves 2MB in everyones vendor folder :)

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that will not help me at Debian packaging, but I will manage to workaround it
Thanks !

@shyim
Copy link
Author

shyim commented Apr 5, 2023

composer package as debian package? 😱

@williamdes
Copy link
Contributor

composer package as debian package? scream

Well, no. But in a sense yes.
Let me explain, the file you just changed controls the command git archive. GitHub uses that to give you nice tarballs on branches and tags/releases.

The tarballs are re-used by packagist/composer. And also packaging people in Debian or other distributions.
See: https://salsa.debian.org/phpmyadmin-team/tcpdf
See: https://salsa.debian.org/phpmyadmin-team/tcpdf/-/blob/debian/6.6.2+dfsg1-1_bpo11+1/debian/watch (the file used by Debian watch )

So if you exclude tests or other files from the git archive, other users who need them will have to use git clone to have them back. It's not very cool but sometimes it's best for everyone to have them excluded from the git archive.
Because at Debian the tests will be run on the source code to ensure the packaged code really works: https://salsa.debian.org/phpmyadmin-team/tcpdf/-/blob/debian/6.6.2+dfsg1-1_bpo11+1/debian/tests/control

Does that help understand ?

@shyim
Copy link
Author

shyim commented Apr 5, 2023

Ahhh okay. Thanks for maintaining phpmyadmin on debian! ❤️

@williamdes
Copy link
Contributor

Ahhh okay. Thanks for maintaining phpmyadmin on debian! ❤️

And more of them ;p
I wrote an article right now: https://blog.williamdes.eu/Debian/the-debian-packages-i-maintain/

@williamdes
Copy link
Contributor

What do you think about this one @nicolaasuni ?
Also, if you accept this, can you GPG sign your tags so I can securely import them into Debian ?

@williamdes williamdes mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants