Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typehints for getHeaderMargin() and setHeaderMargin() are inconsistent #598

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

fisharebest
Copy link
Contributor

This PR just updates a couple of inconsistent type-hints in the phpdoc.

The header/footer margins are both float, but the getters/setters have inconsistent PHPDOC.

getFooterMargin() has @return float, but setFooterMargin() has @param int $fm.

getHeaderMargin() has @return float, but setHeaderMargin() has @param int $hm.

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2023

Codecov Report

Merging #598 (7d76401) into main (2fb1c01) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #598   +/-   ##
=======================================
  Coverage   69.33%   69.33%           
=======================================
  Files         128      128           
  Lines       27022    27022           
=======================================
  Hits        18735    18735           
  Misses       8287     8287           
Flag Coverage Δ
php-5.3-ubuntu-latest 68.85% <ø> (+<0.01%) ⬆️
php-5.4-ubuntu-latest 68.85% <ø> (-0.01%) ⬇️
php-5.5-ubuntu-latest 68.85% <ø> (+<0.01%) ⬆️
php-5.6-ubuntu-latest 68.91% <ø> (ø)
php-7.0-ubuntu-latest 71.59% <ø> (ø)
php-7.1-ubuntu-latest 73.07% <ø> (ø)
php-7.2-ubuntu-latest 72.94% <ø> (-0.01%) ⬇️
php-7.3-ubuntu-latest 72.94% <ø> (ø)
php-7.4-ubuntu-latest 72.93% <ø> (-0.01%) ⬇️
php-8.0-ubuntu-latest 72.94% <ø> (-0.01%) ⬇️
php-8.1-ubuntu-latest 72.94% <ø> (-0.01%) ⬇️
php-8.2-ubuntu-latest 72.94% <ø> (-0.01%) ⬇️
php-nightly-ubuntu-latest 72.94% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tcpdf.php 67.90% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

williamdes
williamdes previously approved these changes Mar 19, 2023
Copy link
Contributor

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's okay, but could you also add @var float on the properties?

@fisharebest
Copy link
Contributor Author

that's okay, but could you also add @var float on the properties?

Sure!

I wasn't sure of the project's policy - so I just changed the external interfaces.

@fisharebest fisharebest changed the title Typehints for getHeaderMargin() and setHeaderMargin() are inconstent Typehints for getHeaderMargin() and setHeaderMargin() are inconsistent Mar 19, 2023
Copy link
Contributor

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR
Now we need to be very patient until it can be merged ;)

@williamdes williamdes mentioned this pull request Aug 2, 2023
@nicolaasuni nicolaasuni merged commit 18d1b2b into tecnickcom:main Sep 6, 2023
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants