-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC - Rolling Time Periods #3
base: main
Are you sure you want to change the base?
Conversation
include some additional test helpers, enable semver checking for migrations
rules.iter_mut().for_each(|rule| { | ||
if rule.flow.is_expired(env.block.time) { | ||
rule.flow.expire(env.block.time, rule.quota.duration); | ||
// is this the correct way to reset the channel value?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it isn't. The channel value is the current amount of tokens (the rate-limited denom) existing on osmosis (see https://github.com/osmosis-labs/osmosis/tree/main/x/ibc-rate-limit#notes-on-channel-value and https://github.com/osmosis-labs/osmosis/blob/ad31bfb16d8ecd476d3700079554b4e8842f9e7f/x/ibc-rate-limit/contracts/rate-limiter/src/packet.rs#L115-L120)
This should be updated now that cosmos/ibc-go#2664 has been merged.
I like this idea |
notes:
BeforeBlock
for handling period rollovers