feat: Add support for new whisper.cpp project structure #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove opencl feature, removed in whisper.cpp Add openmp feature and enable by default as in whisper.cpp Update bindings
Closed
|
Hey |
This was referenced Aug 18, 2024
Merged
|
New major release of whisper-rs will depend on #168 then if OpenCL is gone |
|
Since this update it works 2 times slower on macOS even when coreml and metal features enabled. Any idea why? maybe it doesn't enable it? |
|
@thewh1teagle Maybe it'll be better to create separate issue to continue? |
On Linux / Windows it of course works much faster with Vulkan. the problem is with macOS arm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for new whisper.cpp project structure
Remove opencl feature, removed in whisper.cpp
Add openmp feature and enable by default as in whisper.cpp
Update bindings