Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the package.json to specify the yarn version for corepack #1310

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

stof
Copy link
Member

@stof stof commented Aug 30, 2024

This makes it easier for contributors using corepack as their way of installing yarn (which is the recommended way nowadays)

@Kocal
Copy link
Member

Kocal commented Aug 30, 2024

We should add packageManager config for our test apps aswell

@stof
Copy link
Member Author

stof commented Aug 30, 2024

The packageManager in the main package.json breaks the CI for pnpm jobs because pnpm/action-setup detects conflicts between the packageManager and the specified version in the workflow. I need to investigate that. Maybe the solution is to change the workflow setup to tell pnpm/action-setup to look at the package.json of the test app instead, as that's where we use pnpm. I will investigate that.

We should add packageManager config for our test apps aswell

Indeed. That's a good catch. I'll do it.

This makes it easier for contributors using corepack as their way of
installing yarn (which is the recommended way nowadays)
@stof
Copy link
Member Author

stof commented Aug 30, 2024

The yarn-based testing apps were already defining the packageManager field for corepack. I added it in all the pnpm testing apps, which makes it easier to have the same pnpm version locally than in CI (as the local setup does not care about the workflow definition).

@stof stof merged commit 11d6175 into symfony:main Aug 30, 2024
34 checks passed
@stof stof deleted the corepack branch August 30, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants