minor #1315 Remove useless eslint disabling comments (stof)

This PR was merged into the main branch. Discussion ---------- Remove useless eslint disabling comments Those lines don't report such error. Commits ------- dcfdae1 REmove useless eslint disabling comments
symfony · Aug 31, 2024 · a6cf19f · a6cf19f
2 parents 4605f80 + dcfdae1
commit a6cf19f
Show file tree

Hide file tree

Showing 11 changed files with 12 additions and 12 deletions.
diff --git a/lib/loaders/css.js b/lib/loaders/css.js
@@ -57,7 +57,7 @@ module.exports = {
             };
 
             cssLoaders.push({
-                loader: require.resolve('postcss-loader'), //eslint-disable-line node/no-unpublished-require
+                loader: require.resolve('postcss-loader'),
                 options: applyOptionsCallback(webpackConfig.postCssLoaderOptionsCallback, postCssLoaderOptions)
             });
         }

diff --git a/lib/loaders/handlebars.js b/lib/loaders/handlebars.js
@@ -28,7 +28,7 @@ module.exports = {
 
         return [
             {
-                loader: require.resolve('handlebars-loader'), //eslint-disable-line node/no-unpublished-require
+                loader: require.resolve('handlebars-loader'),
                 options: applyOptionsCallback(webpackConfig.handlebarsConfigurationCallback, options)
             }
         ];

diff --git a/lib/loaders/less.js b/lib/loaders/less.js
@@ -33,7 +33,7 @@ module.exports = {
         return [
             ...cssLoader.getLoaders(webpackConfig, useCssModules),
             {
-                loader: require.resolve('less-loader'), //eslint-disable-line node/no-unpublished-require
+                loader: require.resolve('less-loader'),
                 options: applyOptionsCallback(webpackConfig.lessLoaderOptionsCallback, config)
             },
         ];

diff --git a/lib/loaders/sass.js b/lib/loaders/sass.js
@@ -52,7 +52,7 @@ module.exports = {
         });
 
         sassLoaders.push({
-            loader: require.resolve('sass-loader'), //eslint-disable-line node/no-unpublished-require
+            loader: require.resolve('sass-loader'),
             options: applyOptionsCallback(webpackConfig.sassLoaderOptionsCallback, config)
         });
 

diff --git a/lib/loaders/stylus.js b/lib/loaders/stylus.js
@@ -33,7 +33,7 @@ module.exports = {
         return [
             ...cssLoader.getLoaders(webpackConfig, useCssModules),
             {
-                loader: require.resolve('stylus-loader'), //eslint-disable-line node/no-unpublished-require
+                loader: require.resolve('stylus-loader'),
                 options: applyOptionsCallback(webpackConfig.stylusLoaderOptionsCallback, config)
             },
         ];

diff --git a/lib/loaders/typescript.js b/lib/loaders/typescript.js
@@ -40,7 +40,7 @@ module.exports = {
             config.transpileOnly = true;
 
             // add forked ts types plugin to the stack
-            const forkedTypesPluginUtil = require('../plugins/forked-ts-types'); // eslint-disable-line
+            const forkedTypesPluginUtil = require('../plugins/forked-ts-types');
             forkedTypesPluginUtil(webpackConfig);
         }
 
@@ -54,7 +54,7 @@ module.exports = {
         let loaders = babelLoader.getLoaders(webpackConfig);
         return loaders.concat([
             {
-                loader: require.resolve('ts-loader'), //eslint-disable-line node/no-unpublished-require
+                loader: require.resolve('ts-loader'),
                 // @see https://github.com/TypeStrong/ts-loader/blob/master/README.md#available-options
                 options: config
             }

diff --git a/lib/loaders/vue.js b/lib/loaders/vue.js
@@ -30,7 +30,7 @@ module.exports = {
 
         return [
             {
-                loader: require.resolve('vue-loader'), //eslint-disable-line node/no-unpublished-require
+                loader: require.resolve('vue-loader'),
                 options: applyOptionsCallback(webpackConfig.vueLoaderOptionsCallback, options)
             }
         ];

diff --git a/lib/plugins/notifier.js b/lib/plugins/notifier.js
@@ -33,7 +33,7 @@ module.exports = function(plugins, webpackConfig) {
         title: 'Webpack Encore'
     };
 
-    const WebpackNotifier = require('webpack-notifier'); // eslint-disable-line
+    const WebpackNotifier = require('webpack-notifier');
     plugins.push({
         plugin: new WebpackNotifier(
             applyOptionsCallback(webpackConfig.notifierPluginOptionsCallback, notifierPluginOptions)

diff --git a/lib/plugins/vue.js b/lib/plugins/vue.js
@@ -25,7 +25,7 @@ module.exports = function(plugins, webpackConfig) {
         return;
     }
 
-    const { VueLoaderPlugin } = require('vue-loader'); // eslint-disable-line node/no-unpublished-require
+    const { VueLoaderPlugin } = require('vue-loader');
 
     plugins.push({
         plugin: new VueLoaderPlugin(),

diff --git a/lib/webpack/copy-files-loader.js b/lib/webpack/copy-files-loader.js
@@ -84,7 +84,7 @@ module.exports.default = function loader(source) {
         }
     });
 
-    const fileLoader = require('file-loader'); // eslint-disable-line node/no-unpublished-require
+    const fileLoader = require('file-loader');
 
     // If everything is OK, let the file-loader do the copy
     return fileLoader.bind(this)(source);

diff --git a/package.json b/package.json
@@ -7,7 +7,7 @@
     "test": "yarn run test:main && yarn run test:persistent-cache",
     "test:main": "mocha --reporter spec test --recursive --ignore test/persistent-cache/*",
     "test:persistent-cache": "node run-persistent-tests",
-    "lint": "eslint lib test index.js .eslintrc.js",
+    "lint": "eslint lib test index.js .eslintrc.js --report-unused-disable-directives",
     "travis:lint": "yarn run lint"
   },
   "bin": {