-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shell: add support for vim/hybrid styles in term/ansi-term buffers. #10844
Conversation
Inside a project, a shell is no longer spawned with This is what's printed in
|
Well that sucks, I'm gonna have a look at it when i get home or tomorrow. Did this happen with the same setup you posted in #10956. I've been using it on emacs 26.1 and seems to work just fine but ill investigate. |
I had the same issue as @giuscri. The problem seems to be that
works for me. This is the approach taken by evil-collections. |
Thanks @OkIdeal0, updated pr. |
(when (eq major-mode 'term-mode) | ||
(when (get-buffer-process (current-buffer)) | ||
(term-char-mode) | ||
(if (not (eq (line-number-at-pos (point)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use term-goto-process-mark-maybe
?
I was trying out the vim editing style today and noticed that the cursor is stuck in normal/visual mode in term buffers, you can't move around and you cant edit/copy anything. This solves it.
This commit also ensured the cursor goes to the prompt if the cursor enters insert/hybrid mode from a different line than the prompt line.
Fixes: #10779.