forked from byte-it/openapi-spec-generator
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate documentation for non eloquent resources without extra configuration #18
Open
Rocksheep
wants to merge
5
commits into
master
Choose a base branch
from
non-eloquent-resources
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rocksheep
changed the title
Allow the use of non eloquent resources without extra configuration
Generate documentation for non eloquent resources without extra configuration
Sep 19, 2023
JaZo
requested changes
Sep 29, 2023
JaZo
requested changes
Oct 26, 2023
Rocksheep
force-pushed
the
non-eloquent-resources
branch
3 times, most recently
from
October 15, 2024 10:17
7829a20
to
ac795ae
Compare
Rocksheep
force-pushed
the
non-eloquent-resources
branch
from
October 16, 2024 07:09
ac795ae
to
019f49e
Compare
I have updated the code of the branch and resolved all feedback. Can you check this PR again @JaZo ? |
JaZo
requested changes
Oct 24, 2024
Rocksheep
force-pushed
the
non-eloquent-resources
branch
from
October 24, 2024 17:02
019f49e
to
47934db
Compare
Rocksheep
force-pushed
the
non-eloquent-resources
branch
from
October 24, 2024 17:42
47934db
to
b082261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will allow developers to generate documentation for their non-eloquent resources. This is built upon the code of PR #17 and now it no longer requires the ArrayAccess interface and the all method on the resource.
Motivation and context
This allows developers to generate the missing documentation for their non eloquent resources!
How has this been tested?
Test data has been added to the package which is used to validate the functionality in the tests
Screenshots (if appropriate)
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
If you're unsure about any of these, don't hesitate to ask. We're here to help!