Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2 and v31 trigger option to workflows #127

Closed
wants to merge 3 commits into from
Closed

Conversation

micryc
Copy link
Contributor

@micryc micryc commented Mar 14, 2024

No description provided.

@micryc micryc self-assigned this Mar 14, 2024
Copy link
Member

@frantuma frantuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micryc do we need to have the other branches added here? is it not sufficient to have workflows with same name defined in branches to have them run?

This is confusing and possibly could break things, e.g. if no corresponding file is on branch

Applies to all changes

@micryc
Copy link
Contributor Author

micryc commented Mar 18, 2024

@frantuma yes you are definitely right, having workflows with same names defined in branches is totally enough, except CodeQl workflow ofcourse, because it's not a workflow dispatch and triggers automatically.

@micryc micryc requested a review from frantuma March 25, 2024 10:06
@micryc micryc closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants