Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 ✨ refactor(library): upgrade build scripts, fix type defs, add support for hideOnOutsideClick #38

Merged
merged 18 commits into from
Dec 30, 2023
Merged

🧹 ✨ refactor(library): upgrade build scripts, fix type defs, add support for hideOnOutsideClick #38

merged 18 commits into from
Dec 30, 2023

Conversation

dysfunc
Copy link
Contributor

@dysfunc dysfunc commented Dec 30, 2023

Why these changes?

This PR includes:

  • Adds new feature hideOnOutsideClick that will allow you to hide tooltips that were configured with action click
  • Updates docs and examples for hideOnOutsideClick usage
  • Fixes Typescript defs and introduces linting/checking in the pre-commit hooks
  • Use pnpm instead of npm
  • Updates the unit workflow action to use pnpm
  • Use svelte-package to bundle the library instead of vite + include publint

Closes #33 #34 #35 #37

@dysfunc
docs(api): update docs and examples with hideOnOutsideClick
6ad8907
@dysfunc
refactor(types): update typescript config and add/updare typescript defs
dd8cb84
@dysfunc
chore(tests): update vitest configs and snapshots
4869be4
@dysfunc
chore(tooling): update scripts and deps for bundling, linting, and fo…
0317028 
…rmatting
@dysfunc
feat(hideOnOutsideClick): update component and action to support hide…
b19fa51 
…OnOutsideClick
@dysfunc
ci(actions): update unit tests workflow
352ead0
@dysfunc
chore(pm): use pnpm instead of npm
4618863
@dysfunc
chore(pm): use pnpm instead of npm
a6d5580
@dysfunc
chore(copy): update minor copy changes
9a03c6b
@dysfunc
refactor(handler): adjust onclick handler for action and tooltip
e639d84
@dysfunc
fix(show): fix initial positioning of tooltip using show
9075d6e
@dysfunc
fix(show): fix initial positioning of tooltip using show
fb3ceb2
@dysfunc
fix(action): prevent warning from invalid prop on action component
49d957f
@dysfunc
docs(examples): add example of using show with timer
8afe255
@dysfunc
fix(position): update positioning logic to handle absolute targets co…
2c78635 
…rrectly
@dysfunc
docs(examples): update copy on examples to showcase outside click and…
2dc36a1 
… show
@dysfunc
docs(examples): update copy on examples to showcase outside click and…
07354cd 
… show
@dysfunc
chore(version): update package to v3.0.0
30d30e1
@dysfunc dysfunc added Priority: High Bug, issue, or pull request is a P1 Type: Feature A new feature or functionality Type: Bug Something isn't working Type: Refactor Enhancements, deletions, etc. to existing code labels Dec 30, 2023
@dysfunc dysfunc added this to the v3.0.0 milestone Dec 30, 2023
@dysfunc dysfunc self-assigned this Dec 30, 2023
@dysfunc dysfunc added the Type: CI/CD Issue or pull request contain infrastructure changes only label Dec 30, 2023
@dysfunc dysfunc merged commit a69d84e into main Dec 30, 2023
1 check passed
@dysfunc dysfunc deleted the v3.0 branch December 30, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dysfunc dysfunc

Labels
Priority: High Bug, issue, or pull request is a P1 Type: Bug Something isn't working Type: CI/CD Issue or pull request contain infrastructure changes only Type: Feature A new feature or functionality Type: Refactor Enhancements, deletions, etc. to existing code
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

✨ Don't show multiple tooltips at once
1 participant
@dysfunc