Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update approvals in routerplus [SUP-8878] #643

Draft
wants to merge 17 commits into
base: v1.5
Choose a base branch
from
Draft

fix: update approvals in routerplus [SUP-8878] #643

wants to merge 17 commits into from

Conversation

TamaraRingas
Copy link

  • add global slippage parameter
  • add and test setter for global slippage
  • add additional slippage checks to _rebalancePositionsSync()
  • update _deposit() call in _rebalancePositionsSync() to use amountIn instead of amountToDeposit

@TamaraRingas TamaraRingas self-assigned this Oct 21, 2024
@linear Linear
Copy link

linear bot commented Oct 21, 2024

SUP-8878 Fix approvals in RouterPlus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTimepunk 0xTimepunk Awaiting requested review from 0xTimepunk

At least 1 approving review is required to merge this pull request.

Assignees

@TamaraRingas TamaraRingas

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TamaraRingas @0xTimepunk