Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: command tag oid now shows up in string #211

Merged
merged 1 commit into from
Oct 20, 2024
Merged

fix: command tag oid now shows up in string #211

merged 1 commit into from
Oct 20, 2024

Conversation

jennykwan
Copy link
Contributor

At least with the psql client, execution command strings without oid print a notice: could not interpret result from server: <string>.

This PR changes the serialization of Tag to CommandComplete by adding oid between the tag and rows.

The case of Some(oid) and None rows is not covered, because it would serialize in an ambiguous way. This means that oid will be ignored if rows is None.

sunng87
sunng87 approved these changes Oct 20, 2024
View reviewed changes
Copy link
Owner

@sunng87 sunng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunng87 sunng87 merged commit 2e90c67 into sunng87:master Oct 20, 2024
6 checks passed
@sunng87
Copy link
Owner

sunng87 commented Oct 20, 2024

@jennykwan Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunng87 sunng87 sunng87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennykwan @sunng87