Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TimeCardContinue.fx.yaml #2

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Update TimeCardContinue.fx.yaml #2

merged 1 commit into from
Jun 12, 2024

Conversation

sudhirke
Copy link
Owner

@sudhirke sudhirke commented Jun 12, 2024

Screen: My Timesheets
When records are submitted with status "Submitted for approval", manager information should be updated with current user's manager. Instead it was being submitted as current user with status "Submitted for Approval"

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

To submit a pull request with multiple authors, make sure that at least one commit is a co-authored commit by adding a Co-authored-by: trailer to the commit's message. E.g.: Co-authored-by: name <name@example.com>

Put an x in all the items that apply ([x], without spaces), make notes next to any that haven't been addressed.

What's in this Pull Request?

This resolves an issue that I logged for this repository. On the TimeSheet Continue screen whenever you submit the updates, it was resetting the manager information to current user and keeping status as "Submitted for Approval". I have updated the onSubmit1_onClick event to update user's manager details whenever the updated timesheet are submitted.

Checklist

This checklist is mostly useful as a reminder of small things that can easily be forgotten – it is meant as a helpful tool rather than hoops to jump through.

Put an x in all the items that apply ([x], no spaces), make notes next to any that haven't been addressed.

  • My pull request affects only ONE sample.
  • I have updated the README file.
  • My README has at least one static high-resolution screenshot (i.e. not a GIF)
  • My README contains complete setup instructions, including pre-requisites and permissions required

Screen: My Timesheets
When records are submitted with status "Submitted for approval",  manager information should be updated with current user's manager.  Instead it was being submitted as current user with status "Submitted for Approval"
@sudhirke sudhirke merged commit 5227721 into main Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manager details are not updated when saving / submitting from My Timesheet's screen
1 participant