Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] Update keywords-parens for alignof and static_assert #4078

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

braewoods
Copy link
Contributor

I overlooked this previously but I believe this is an optimization for sizeof that would also apply these two that I previously added.

@deathaxe
Copy link
Collaborator

Small tests would probably avoid regressing that change by future changes.

I overlooked this previously but I believe this is an optimization
for sizeof that would also apply these two that I previously added.
@braewoods
Copy link
Contributor Author

What would you suggest then? I already added tests for these previously.

@deathaxe
Copy link
Collaborator

deathaxe commented Oct 31, 2024

Obviously not for parenthesed variants, I guess. Otherwise they would have been failing due this commit missing.

It turns out the keywords-parens to be redundant, because both keywords (e.g. sizeof and parentheses aka. groups are already matched by other patterns.

@braewoods
Copy link
Contributor Author

It turns out the keywords-parens to be redundant, because both keywords (e.g. sizeof and parentheses aka. groups are already matched by other patterns.

Should they be removed then?

@deathaxe
Copy link
Collaborator

There are more such constructs. Not familiar enough with the syntax definition's architecture to say that for sure. Maybe safer to keep them until a rewrite.

@deathaxe deathaxe merged commit 3e062ce into sublimehq:master Oct 31, 2024
1 check passed
@braewoods braewoods deleted the c-parens branch October 31, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants