updated role creation #176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vs2961
requested changes
Jun 30, 2020
app/graphql/resolvers/create_user.rb
Outdated
| if args["role"] and role != nil and !@new_user.roles.include?(role) | ||
| @new_user.roles << role | ||
| args["role"].each do |role| | ||
| roley = Role.find_by(title: role) |
There was a problem hiding this comment.
There's a naming convention for variables in this case, and they're usually named with an @ before the name. In this instance, the name would be @role
app/graphql/resolvers/update_user.rb
Outdated
| @user.roles << role | ||
| @user.roles.clear | ||
| args["role"].each do |role| | ||
| roley = Role.find_by(title: role) |
|
Yeah, renamed the variable so now it follows the norms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #158. Edits the user mutation so that it can accept arrays of roles instead of singular roles. Links to stuyspec/cms#45, so both pull requests must be approved for the change to be properly implemented.