Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Expand from embedded Params to individual Params structs #1703

Merged
merged 6 commits into from
Aug 10, 2023

Conversation

richardm-stripe
Copy link
Contributor

Do what #1641 did for Metadata, but for the Expand field.

Also rearranges the structs so Metadata and Expand appears at the top.

@richardm-stripe richardm-stripe changed the base branch from master to sdk-release/next-major August 10, 2023 18:56
account.go Outdated Show resolved Hide resolved
@remi-stripe
Copy link
Contributor

remi-stripe commented Aug 10, 2023

Also rearranges the structs so Metadata and Expand appears at the top.

Curious why? Metadata is a normal parameter, having it appear in alphabetical order makes more sense to me

Copy link
Contributor

@pakrym-stripe pakrym-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I'm not sure we need AddExpand helper

@richardm-stripe
Copy link
Contributor Author

@remi-stripe no longer moving .Expand and .Metadata to the top.

@richardm-stripe richardm-stripe merged commit b38eae5 into sdk-release/next-major Aug 10, 2023
7 checks passed
@richardm-stripe richardm-stripe deleted the richardm-hoist-expand branch August 10, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants