Add basic Extension support.
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrhee-stripe
changed the title
Extension support.
bplunkett-stripe
requested changes
Jul 13, 2023
|
@bplunkett-stripe , thanks for the feedback! I think this is ready for another look. |
bplunkett-stripe
requested changes
Jul 14, 2023
| @@ -28,6 +28,7 @@ pg-schema-diff plan --dsn "postgres://postgres:postgres@localhost:5432/postgres" | |||
| - Partitions | |||
| - Functions/Triggers (functions created by extensions are ignored) | |||
| - Sequences | |||
| - Extensions | |||
bplunkett-stripe
previously approved these changes
Jul 14, 2023
alexrhee-stripe
force-pushed
the
alexrhee/extension-support
branch
2 times, most recently
from
98c8e6b
to
42d0bf8
Compare
bplunkett-stripe
approved these changes
Jul 17, 2023
alexrhee-stripe
force-pushed
the
alexrhee/extension-support
branch
from
14fc3db
to
e38d696
Compare
bplunkett-stripe
approved these changes
Jul 17, 2023
alexrhee-stripe
force-pushed
the
alexrhee/extension-support
branch
from
5800453
to
2caaee7
Compare
alexrhee-stripe
force-pushed
the
alexrhee/extension-support
branch
from
2caaee7
to
d3084ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We add basic
extensionsupport. This will allow declarative DDL sources to instruct the tooling to create, alter, and delete extensions so that other DDL statements dependent on these extensions are executable.Note that the full gamut of extension DDL is not currently supported, namely the ability to target and move extensions across schemas. Insofar as the schema migration tooling assumes everything is on the
publicschema, I think this is OK for now and can be implemented in a later PR.Motivation
We need
extensionsupport.Testing
Unit tests were added and current tests were augmented. As a result of this change, we removed the
onDbInitQuerieshook since extensions are actually supported and would otherwise require adjusting every single test case. In its stead, I altered theinternal/migration_acceptance_tests/function_cases_test.goto include a case with an extension known to create functions and we observe they are correctly ignored.