-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C implementation for math/base/special/nanmin
#3004
Conversation
lib/node_modules/@stdlib/math/base/special/nanmin/benchmark/c/native/benchmark.c
Show resolved
Hide resolved
The CI errors look similar to what we face here: #3001 (comment) |
…/gunjjoshi/3004
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
@Planeshifter Upgrading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @gunjjoshi.
I'll go ahead and merge, as it seems like the C lint error is spurious.
Description
This pull request:
math/base/special/nanmin
.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers