-
-
Notifications
You must be signed in to change notification settings - Fork 448
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat!: improve type declarations for
utils/map-arguments
This change significantly improves the type definition of the mapArguments function, transitioning from broad 'Function' types to specific, generic types and implementing conditional this context based on thisArg presence. BREAKING CHANGE: function signature and return type now more strictly typed The mapArguments function now uses generic types instead of 'Function', and its return type depends on thisArg presence. Users should review and update their usage of mapArguments, particularly: - Ensure provided functions match the new, stricter type requirements - Update any type assertions or checks where mapArguments is used - Pay special attention to contexts where this binding is significant PR-URL: #2050 Closes: #1087 Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: Prajwal Kulkarni <prajwalkulkarni76@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
- Loading branch information
1 parent
e5b993a
commit b74a08a
Showing
2 changed files
with
74 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b74a08a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage Report
The above coverage report was generated for the changes in this push.