Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for v0.10.5 #91

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Docs for v0.10.5 #91

merged 4 commits into from
Dec 22, 2023

Conversation

MuneebAijaz
Copy link
Contributor

No description provided.

@MuneebAijaz MuneebAijaz changed the base branch from main to 0.10 December 22, 2023 10:59

#### Fix

- `TemplateGroupInstance` controller now correctly updates the its status and the namespace count upon the deletion of a namespace.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
A determiner cannot be combined with a possessive pronoun. Did you mean simply “the” or “its”? (A_MY[136])
Suggestions: the, its
Rule: https://community.languagetool.org/rule/show/A_MY?lang=en-US&subId=136
Category: COLLOCATIONS

content/faq.md Outdated
unable to find annotation openshift.io/sa.scc.uid-range
```

**Answer.** Openshift recently updated its process of handling SCC and it's now managed by annotations like `openshift.io/sa.scc.uid-range` on the namespaces. Absense of them wont let pods schedule. The fix for the above error is to make sure ServiceAccount `system:serviceaccount:openshift-infra.` regex is always mentioned in `PrivilegedServiceAccounts` section of `IntegrationConfig`. This regex will allow operations from all `ServiceAccounts` present in `openshift-infra` namespace. More info at [Privileged Service Accounts](./integration-config.md#privileged-serviceaccounts)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE[1])
Suggestions: , and
URL: https://languagetool.org/insights/post/types-of-sentences/#compound-sentence
Rule: https://community.languagetool.org/rule/show/COMMA_COMPOUND_SENTENCE?lang=en-US&subId=1
Category: PUNCTUATION

@@ -51,8 +51,7 @@ As we can see, in our TGI, we have a field `spec.sync` which is set to `true`. T
- If, for any reason, the underlying resource gets updated or deleted, `TemplateGroupInstance` CR will try to revert it back to the state mentioned in the `Template` CR.

!!! note
If the updated field of the deployed manifest is not mentioned in the Template, it will not get reverted.
For example, if `secrets` field is not mentioned in ServiceAcoount in the above Template, it will not get reverted if changed
Updates to ServiceAccounts are ignored by both, reconciler and informers, in an attempt to avoid conflict between the TGI controller and Kube Controller Manager. ServiceAccounts are only reverted back in case of unexpected deletions when sync is true.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Consider using just “reverted”. (RETURN_BACK[1])
Suggestions: reverted
Rule: https://community.languagetool.org/rule/show/RETURN_BACK?lang=en-US&subId=1
Category: REDUNDANCY

Copy link

@MuneebAijaz Image is available for testing. docker pull nexus-docker-stakater-nexus.apps.preprod.jlvwjls8.kubeapp.cloud/stakater/mto-docs:SNAPSHOT-PR-91-1c72fd0f

@thunef
Copy link

thunef commented Dec 22, 2023

Looking great! ✔️ However, I don't know what I feel about that content/explanation/logs-metrics.md is a duplication! Should this the be source of truth instead and have MTO repo docs link to this page instead?

@MuneebAijaz
Copy link
Contributor Author

Looking great! ✔️ However, I don't know what I feel about that content/explanation/logs-metrics.md is a duplication! Should this the be source of truth instead and have MTO repo docs link to this page instead?

I think it's fine to keep it at both places. In Mto repo its more related to developer, here its related to customer/user

@MuneebAijaz MuneebAijaz merged commit 0b56b0e into 0.10 Dec 22, 2023
7 checks passed
@MuneebAijaz MuneebAijaz deleted the 0.10.5 branch December 22, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants