Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deployment): allow setting replicas to zero #minor #352

Merged
merged 2 commits into from
Oct 1, 2024
Merged

feat(deployment): allow setting replicas to zero #minor #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd01f83
allow setting replicas to zero
ElfoLiNk Oct 1, 2024
af09020
Change replicas check condition
ElfoLiNk Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion application/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ metadata:
name: {{ template "application.name" . }}
namespace: {{ include "application.namespace" . }}
spec:
{{- if .Values.deployment.replicas }}
{{- if not (eq .Values.deployment.replicas nil) }}
replicas: {{ .Values.deployment.replicas }}
{{- end }}
selector:
Expand Down
8 changes: 8 additions & 0 deletions application/tests/deployment_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ tests:
path: metadata.labels["app.kubernetes.io/version"]
value: example-tag

- it: allows setting replicas zero
set:
deployment.replicas: 0
asserts:
- equal:
path: spec.replicas
value: 0

- it: uses image digest when given
set:
deployment.image.repository: example-image
Expand Down
Loading