Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added new tests #349

Merged
merged 7 commits into from
Sep 27, 2024
Merged

added new tests #349

merged 7 commits into from
Sep 27, 2024

Conversation

aayeshaarshad
Copy link
Contributor

@aayeshaarshad aayeshaarshad commented Sep 26, 2024 •
edited
Loading

Added unit tests for following templates

  • alertmanagerconfig
  • backup
  • certificate
  • configmap
  • forecastle
  • grafanadashboard
  • ingress
  • networkpoliciy
  • prometheusrule
  • role
  • rolebinding
  • sercretproviderclass
  • service
  • servicemonitor
  • vpa

@aslafy-z aslafy-z marked this pull request as draft September 26, 2024 14:25
@aayeshaarshad aayeshaarshad marked this pull request as ready for review September 27, 2024 12:57
@rasheedamir
Copy link
Member

@aslafy-z can you please review this PR?

aslafy-z
aslafy-z approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@aslafy-z aslafy-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aslafy-z aslafy-z merged commit 98367dd into master Sep 27, 2024
2 checks passed
@aslafy-z aslafy-z deleted the tests branch September 27, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslafy-z aslafy-z aslafy-z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aayeshaarshad @rasheedamir @aslafy-z