feat: generated Helm documentation #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aslafy-z validation successful` |
aslafy-z
force-pushed
the
feat/generated-readme
branch
2 times, most recently
from
db29820
to
ba729be
Compare
aslafy-z
force-pushed
the
feat/generated-readme
branch
from
58845d9
to
8293e8b
Compare
aslafy-z
force-pushed
the
feat/generated-readme
branch
5 times, most recently
from
0965b2a
to
27ef4ff
Compare
|
@karl-johan-grahn @d3adb5 can you guys review it? |
karl-johan-grahn
previously approved these changes
Jul 28, 2024
SheryarButt
reviewed
Aug 28, 2024
Signed-off-by: GitHub <noreply@github.com>
aslafy-z
force-pushed
the
feat/generated-readme
branch
from
19d1451
to
2e48549
Compare
|
looks good to me! great work @aslafy-z |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview at https://github.com/stakater/application/blob/feat/generated-readme/README.md
certificate.issuerRef.grouptocert-manager.ioThanks to norwoodj/helm-docs#260, we will soon be able to render a bit better some of the default values.
Fixes #242