Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of vpa.updatePolicy #288

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

pauvos
Copy link
Contributor

@pauvos pauvos commented Nov 17, 2023

Support for vpa.updatePolicy.updateMode=Auto|Recreate|Initial|Off (default is Auto)

$ helm template application --set=vpa.enabled='true' --validate | grep -A1 updatePolicy
  updatePolicy:
    updateMode: Auto

also works for other updatePolicy settings

$ helm template application --set=vpa.enabled='true' \
  --set=vpa.updatePolicy.updateMode=Off \
  --set=vpa.updatePolicy.minReplicas=3 --validate | grep -A2 updatePolicy
  updatePolicy:
    minReplicas: 3
    updateMode: "Off"

Link to CRD for reference: https://github.com/kubernetes/autoscaler/blob/vertical-pod-autoscaler-1.0.0/vertical-pod-autoscaler/deploy/vpa-v1-crd-gen.yaml#L377

Copy link

@pauvos validation successful`

@rasheedamir
Copy link
Member

@d3adb5 can you please review it?

Copy link
Collaborator

@d3adb5 d3adb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rasheedamir rasheedamir merged commit 051b4a3 into stakater:master Nov 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants