Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow multiple cronjobs #271

Merged
merged 4 commits into from
Sep 26, 2023
Merged

fix: allow multiple cronjobs #271

merged 4 commits into from
Sep 26, 2023

Conversation

aslafy-z
Copy link
Collaborator

@aslafy-z aslafy-z commented Sep 22, 2023

The cronjob template misses a --- new document separation. This means all cronjobs are scrambled together and only a frankenstein version of all of them is emitted.
This PR also does some lint:

  • move the new document separator to the beginning of templates
  • add empty newline at the end of files
  • remove empty newlines in the middle of files
  • move helpers to _helpers file.

Signed-off-by: GitHub <noreply@github.com>
Copy link
Collaborator

@d3adb5 d3adb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would normally be wary of changes to whitespace, as they unnecessarily mess with blame information, but in this case they're only present at the end of each file and I doubt we'll run into any issues as a result.

LGTM! 👍

@github-actions
Copy link

@mustafaStakater validation successful`

@rasheedamir rasheedamir merged commit d58de36 into master Sep 26, 2023
2 checks passed
@rasheedamir rasheedamir deleted the fix/multiple-cronjob branch September 26, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants