-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add topologySpreadConstraints #239
Conversation
@aslafy-z validation successful` |
@mustafaStakater Can you please have a look? |
I will look into automating changelog updates @aslafy-z |
@aslafy-z maybe we should merge this PR by updating the changelog manually and don't hold this one for automatic updates of changelog? |
Co-authored-by: d3adb5 <me@d3adb5.net>
@aslafy-z i will suggest we add tests like these for this change? https://github.com/stakater/application/tree/master/application/tests |
@rasheedamir I was not sure if such a proxified value with no transformation needed a test. What do you think? Would love to get @d3adb5 's opinion too |
I'm with @aslafy-z on this one. Trying to think of it in terms of what we might test in a real program, there's no logic beyond accessing variables and ensuring |
Add values for topologySpreadConstraints