Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add topologySpreadConstraints #239

Merged
merged 6 commits into from
Apr 1, 2023
Merged

Conversation

aslafy-z
Copy link
Collaborator

@aslafy-z aslafy-z commented Mar 27, 2023

Add values for topologySpreadConstraints

@github-actions
Copy link

@aslafy-z validation successful`

@aslafy-z aslafy-z marked this pull request as ready for review March 27, 2023 15:19
@aslafy-z
Copy link
Collaborator Author

aslafy-z commented Mar 29, 2023

@mustafaStakater Can you please have a look?
Also, this changelog updates and way the releases are done is counterintuitive, I'd like to see semantic-release like automatic versioning in such a simple repository. I will open an issue about that.
Edit: Here it is #241

@mustafaStakater
Copy link
Contributor

I will look into automating changelog updates @aslafy-z

@aslafy-z aslafy-z marked this pull request as draft March 31, 2023 18:18
@rasheedamir
Copy link
Member

@aslafy-z maybe we should merge this PR by updating the changelog manually and don't hold this one for automatic updates of changelog?

@aslafy-z aslafy-z marked this pull request as ready for review April 1, 2023 12:50
@rasheedamir
Copy link
Member

@aslafy-z i will suggest we add tests like these for this change? https://github.com/stakater/application/tree/master/application/tests

@aslafy-z
Copy link
Collaborator Author

aslafy-z commented Apr 1, 2023

@rasheedamir I was not sure if such a proxified value with no transformation needed a test. What do you think? Would love to get @d3adb5 's opinion too

@d3adb5
Copy link
Collaborator

d3adb5 commented Apr 1, 2023

I'm with @aslafy-z on this one. Trying to think of it in terms of what we might test in a real program, there's no logic beyond accessing variables and ensuring with works as intended — which is language behavior — to test, so the unit test would be trivial and unnecessary at best.

@rasheedamir rasheedamir merged commit 398397a into stakater:master Apr 1, 2023
@aslafy-z aslafy-z deleted the patch-2 branch April 1, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants